Ticket #345 (closed defect: fixed)

Opened 3 months ago

Last modified 3 months ago

Issues with Python 2.6 float tests

Reported by: thijs Owned by: nick
Priority: major Milestone: 0.4
Component: Testing Version: 0.3.1
Keywords: Cc:

Description

Currently the buildbot shows the following failures for 2.6: 

======================================================================
ERROR: test_infinites (test_amf0.DecoderTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/buildbot/slaves/pyamf/amd64-ubuntu-py26/build/pyamf/tests/test_amf0.py", line 514, in test_infinites
    x = self.decoder.readElement()
  File "/home/buildbot/slaves/pyamf/amd64-ubuntu-py26/build/pyamf/__init__.py", line 495, in readElement
    return func()
  File "/home/buildbot/slaves/pyamf/amd64-ubuntu-py26/build/pyamf/amf0.py", line 225, in readNumber
    return _check_for_int(self.stream.read_double())
  File "/home/buildbot/slaves/pyamf/amd64-ubuntu-py26/build/pyamf/amf0.py", line 916, in _check_for_int
    y = int(x)
ValueError: cannot convert float NaN to integer

======================================================================
ERROR: test_number_types (test_amf0.DecoderTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/buildbot/slaves/pyamf/amd64-ubuntu-py26/build/pyamf/tests/test_amf0.py", line 508, in test_number_types
    self.assertEquals(type(self.decoder.readElement()), expected_type)
  File "/home/buildbot/slaves/pyamf/amd64-ubuntu-py26/build/pyamf/__init__.py", line 495, in readElement
    return func()
  File "/home/buildbot/slaves/pyamf/amd64-ubuntu-py26/build/pyamf/amf0.py", line 225, in readNumber
    return _check_for_int(self.stream.read_double())
  File "/home/buildbot/slaves/pyamf/amd64-ubuntu-py26/build/pyamf/amf0.py", line 916, in _check_for_int
    y = int(x)
ValueError: cannot convert float NaN to integer

----------------------------------------------------------------------

Details on this page.

Change History

Changed 3 months ago by nick

  • keywords review added
  • status changed from new to assigned
  • owner changed from nick to thijs

Buildbots now show: 

Ran 475 tests in 19.750s

PASSED (successes=475)

Changed 3 months ago by thijs

  • owner changed from thijs to nick

Looks good on my mac as well. Merge.

Changed 3 months ago by thijs

Also echo tested it btw.

Changed 3 months ago by thijs

  • keywords review removed

Changed 3 months ago by nick

  • status changed from assigned to closed
  • resolution set to fixed

Merged in r1641.

Note: See TracTickets for help on using tickets.