Ticket #322 (closed enhancement: fixed)

Opened 2 months ago

Last modified 8 weeks ago

Check for non-default __init__ args

Reported by: thijs Owned by: nick
Priority: major Milestone: 0.4
Component: Client Version: 0.3.1
Keywords: Cc: mvtellingen

Description (last modified by thijs) (diff)

See attached log for the errors this Twisted/SQLAlchemy server with this client generated, tested against r1464/r1525 (with the SQLAlchemy patch) and: 

Twisted 8.1.0
PyAMF 0.4.0
SQLAlchemy 0.5.0beta1

Attachments

error-322.txt (4.1 kB) - added by thijs 8 weeks ago.
client.py (385 bytes) - added by thijs 8 weeks ago.
server.py (4.4 kB) - added by thijs 8 weeks ago.
client_mvt_322.py (0.6 kB) - added by mvtellingen 8 weeks ago.
correct client.py
pyamf_classalias.diff (2.1 kB) - added by mvtellingen 8 weeks ago.

Change History

  Changed 2 months ago by thijs

  • description modified (diff)

  Changed 2 months ago by thijs

  • keywords sqlalchemy added
  • description modified (diff)

follow-up: ↓ 4   Changed 8 weeks ago by thijs

  • cc mvtellingen added
  • owner changed from nick to mvtellingen
  • status changed from new to assigned
  • component changed from Encoder to Adapters
  • milestone changed from 0.5 to 0.4

in reply to: ↑ 3 ; follow-up: ↓ 5   Changed 8 weeks ago by mvtellingen

This seems to work for me with the latest patch from http://pyamf.org/ticket/277 Could you confirm it? Thanks

Changed 8 weeks ago by thijs

Changed 8 weeks ago by thijs

Changed 8 weeks ago by thijs

in reply to: ↑ 4   Changed 8 weeks ago by thijs

  • description modified (diff)

Replying to mvtellingen:

This seems to work for me with the latest patch from http://pyamf.org/ticket/277 Could you confirm it? Thanks

Tested it with the patch from #277 and getting a slightly different error now.

Changed 8 weeks ago by mvtellingen

correct client.py

Changed 8 weeks ago by mvtellingen

  Changed 8 weeks ago by mvtellingen

  • keywords review added; sqlalchemy removed
  • owner changed from mvtellingen to nick
  • type changed from defect to enhancement
  • component changed from Adapters to Client
  • priority changed from major to minor

  Changed 8 weeks ago by nick

Looks good.

  Changed 8 weeks ago by thijs

  • keywords review removed
  • summary changed from EncodeError: Unable to determine object attributes to Check for non-default __init__ args

  Changed 8 weeks ago by nick

  • status changed from assigned to closed
  • resolution set to fixed

Added in r1529.

  Changed 8 weeks ago by thijs

  • priority changed from minor to major
  • status changed from closed to reopened
  • resolution fixed deleted

It's incompatible with Python 2.3 and 2.4 it seems: http://buildbot.pyamf.org/builders/amd64-ubuntu-trunk-py24/builds/397/steps/python2.4-test/logs/stdio

  Changed 8 weeks ago by nick

  • status changed from reopened to closed
  • resolution set to fixed

Fixed in r1533.

Note: See TracTickets for help on using tickets.