Server name in HTTP response

[thijs]

Would be nice to replace the default:

WSGIServer/0.1 Python 2.5.2

with:

PyAMF/0.3.1 Python 2.5.2

The attached patch updates the server name for all gateways.

[thijs]

Attached patch, assigning to Nick for review.

[thijs]

Client debug output shows it works:

2008-06-20 17:38:18,215 INFO     Connecting to http://localhost:8000
2008-06-20 17:38:18,215 DEBUG    Service name: pygment
2008-06-20 17:38:18,216 INFO     Adding request: pygment.highlight('Python', 'print "Hello World"')
2008-06-20 17:38:18,216 DEBUG    Executing single request: /1
2008-06-20 17:38:18,218 DEBUG    Sending POST request to: 
2008-06-20 17:38:18,220 DEBUG    Waiting for the response...
2008-06-20 17:38:18,289 INFO     Got response status: 200
2008-06-20 17:38:18,290 DEBUG    Content-Type: application/x-amf
2008-06-20 17:38:18,290 DEBUG    Content-Length: 182
2008-06-20 17:38:18,290 DEBUG    Server: PyAMF/0.4.0 Python/2.5.2
2008-06-20 17:38:18,290 DEBUG    Read 182 bytes for the response
2008-06-20 17:38:18,291 DEBUG    Response: <Envelope amfVersion=0 clientType=0>
 (u'/1', <Response status=/onResult><MarkupVO id=1></Response>)
</Envelope>
2008-06-20 17:38:18,292 DEBUG    Removing request: /1

[thijs]

Updated patch for Server header

[thijs]

Created a branch that includes an update of the patch and more.

[nick]

Patch looks good. Please merge.

[thijs]

Applied to the trunk in r1474.

[nick]

See #326

[nick]

Branching to source:pyamf/branches/server-name-317-2

[nick]

Removed the platform import

[thijs]

Few things while testing with Python 2.4:

• This print in the tests should probably go:

  pyamf.tests.gateway.test_wsgi.WSGIServerTestCase.test_bad_request ... No handlers could be found for logger "pyamf.remoting.gateway.wsgi.WSGIGateway.0x140bd30"
  

• This test is failing:

  ===============================================================================
  [ERROR]: adapters.test_django.TypeMapTestCase.test_NOT_PROVIDED
  
  Traceback (most recent call last):
    File "/usr/local/lib/python2.4/unittest.py", line 260, in run
      testMethod()
    File "/Volumes/collab1/Sites/software/pyamf/pyamf/branches/server-name-317-2/pyamf/tests/adapters/test_django.py", line 72, in test_NOT_PROVIDED
      from django.db.models import fields
    File "/Volumes/collab1/Sites/software/django/django/db/models/__init__.py", line 4, in ?
      from django.db import connection
  exceptions.ImportError: cannot import name connection
  -------------------------------------------------------------------------------
  

Will now test with (and add) a Python remoting client.

[thijs]

Replying to thijs:

Few things while testing with Python 2.4: - This print in the tests should probably go: {{{ pyamf.tests.gateway.test_wsgi.WSGIServerTestCase.test_bad_request ... No handlers could be found for logger "pyamf.remoting.gateway.wsgi.WSGIGateway.0x140bd30"

This one is also visible when running the unit tests with Python 2.5. The Django one isn't visible because Django is properly installed on 2.5

[thijs]

Replying to thijs:

Few things while testing with Python 2.4: - This print in the tests should probably go: {{{ pyamf.tests.gateway.test_wsgi.WSGIServerTestCase.test_bad_request ... No handlers could be found for logger "pyamf.remoting.gateway.wsgi.WSGIGateway.0x140bd30" }}}

This looks fixed after r1497.

[thijs]

Replying to thijs:

- This test is failing: =============================================================================== [ERROR]: adapters.test_django.TypeMapTestCase?.test_NOT_PROVIDED Traceback (most recent call last): File "/usr/local/lib/python2.4/unittest.py", line 260, in run testMethod() File "/Volumes/collab1/Sites/software/pyamf/pyamf/branches/server-name-317-2/pyamf/tests/adapters/test_django.py", line 72, in test_NOT_PROVIDED from django.db.models import fields File "/Volumes/collab1/Sites/software/django/django/db/models/init.py", line 4, in ? from django.db import connection exceptions.ImportError?: cannot import name connection -------------------------------------------------------------------------------

My local Python2.4 installation is probably broken, when I run import os; print os it gives a Bus Error. Testing it on a different Python2.4 doesnt throw the error so this is probably impossible to reproduce on other machines.

[thijs]

Tested the branch with the attached server and client and looks good to me. Also attached a small patch that fixes some of the log statements and adds a log print for the 'Server' http header value.

[nick]

Merged in r1499.