Referer missing in remoting client

[thijs]

Best option would be to leave it blank by default, but giving the option to modify it.

1.2.3.4 - - [06/Jun/2008:15:15:35 -0500] "POST /gateway/bytearray/ HTTP/1.1" 200 135 "client.py" "PyAMF/0.4.0"

[thijs]

Branch ready for review, assigning to Nick.

[nick]

From Wikipedia:

The referer, or HTTP referer, identifies, from the point of view of an internet webpage or resource, the address of the webpage (commonly the URL, the more generic URI or the i18n updated IRI) of the resource which links to it. By checking the referer, the new page can see where the request came from.

So setting the referer to a script name makes no sense, however I can see the value of setting the referer easily as part of the client api.

The default referer argument should be None and only set the corresponding header when a none None value is encountered.

Once that is done, I'll look into the branch in further detail.

[thijs]

Updated the branch in r1465. Will create a new separate branch or patch for the referer. Also attached a test client.

[thijs]

referer test app

[thijs]

See attached patch for a fix.

[nick]

Some small comments:

• self.referer != None should be self.referer is not None
• some whitespace needs to be cleaned up
• DEFAULT_REFERER is not strictly necessary as the value is None

Once all that is done, I'm happy.

[thijs]

Patch against r1464

[thijs]

Replying to nick:

Some small comments: * self.referer != None should be self.referer is not None * some whitespace needs to be cleaned up * DEFAULT_REFERER is not strictly necessary as the value is None Once all that is done, I'm happy.

I made the adjustments and attached an updated patch, ready for review.

[nick]

Okay to merge.

[thijs]

Merged patch in r1466.