TypeError when returning a tuple using TwistedGateway

[jacintos]

This is the relevant part of the stack trace I get:

2008-06-18 06:37:32-0400 [-] --- <exception caught here> ---
2008-06-18 06:37:32-0400 [-]   File "/usr/local/py-sandbox/lib/python2.5/site-packages/Twisted-8.1.0-py2.5-linux-i686.egg/twisted/internet/defer.py", line 328, in _runCallbacks
2008-06-18 06:37:32-0400 [-]     self.result = callback(self.result, *args, **kw)
2008-06-18 06:37:32-0400 [-]   File "/usr/local/src/pyamf/pyamf/remoting/gateway/twisted.py", line 71, in response_cb
2008-06-18 06:37:32-0400 [-]     self.gateway.logger.debug("AMF Response: %r" % result)
2008-06-18 06:37:32-0400 [-] exceptions.TypeError: not all arguments converted during string formatting

I am using PyAMF r1433. Same problem with the 0.3.1 release.

An example Twisted service is attached.

[nick]

Silly error, attached patch should fix the issue.

The service should run now ..

[thijs]

test client with logging enabled

[thijs]

Tested with patch and this test client that returned:

DEBUG:pyamf.remoting.client.RemotingService.0xe57bf0:adding request Hello.sayHello()
DEBUG:pyamf.remoting.client.RemotingService.0xe57bf0:executing single request
DEBUG:pyamf.remoting.client.RemotingService.0xe57bf0:sending POST request to /
DEBUG:pyamf.remoting.client.RemotingService.0xe57bf0:waiting for response ...
DEBUG:pyamf.remoting.client.RemotingService.0xe57bf0:got response status=200
DEBUG:pyamf.remoting.client.RemotingService.0xe57bf0:read 45 bytes for the response
DEBUG:pyamf.remoting.client.RemotingService.0xe57bf0:response = <Envelope amfVersion=0 clientType=0>
 (u'/1', <Response status=/onResult>[u'Hi', u'mom']</Response>)
</Envelope>
[u'Hi', u'mom']

Assigning back to Nick.

[nick]

Branching to source:pyamf/branches/twisted-gateway-tuple-313.

[nick]

This branch is now ready for review. Reassigning to Thijs

[thijs]

Tested the branch with the client and ran the unit tests, looks good to me:

DEBUG:pyamf.remoting.client.RemotingService.0xd57830:Adding request Hello.sayHello()
DEBUG:pyamf.remoting.client.RemotingService.0xd57830:Executing single request: /1
DEBUG:pyamf.remoting.client.RemotingService.0xd57830:AMF version: 0
DEBUG:pyamf.remoting.client.RemotingService.0xd57830:Client type: 0
DEBUG:pyamf.remoting.client.RemotingService.0xd57830:Sending POST request to /
DEBUG:pyamf.remoting.client.RemotingService.0xd57830:Waiting for response...
DEBUG:pyamf.remoting.client.RemotingService.0xd57830:Got response status = 200
DEBUG:pyamf.remoting.client.RemotingService.0xd57830:Content-Type = application/x-amf
DEBUG:pyamf.remoting.client.RemotingService.0xd57830:Content-Length = 45
DEBUG:pyamf.remoting.client.RemotingService.0xd57830:Read 45 bytes for the response
DEBUG:pyamf.remoting.client.RemotingService.0xd57830:Response = <Envelope amfVersion=0 clientType=0>
 (u'/1', <Response status=/onResult>[u'Hi', u'mom']</Response>)
</Envelope>
DEBUG:pyamf.remoting.client.RemotingService.0xd57830:Removing request: /1
[u'Hi', u'mom']

[nick]

Fixed in r1500.